Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system token old payg #1299

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add system token old payg #1299

wants to merge 5 commits into from

Conversation

jesusbv
Copy link
Collaborator

@jesusbv jesusbv commented Mar 13, 2025

Description

Because regsharing checks the whole key (login + pass + system_token)
all systems in the Public Cloud need to have the proper system_token

Update get_system method

Include PAYG/HYBRID system when getting the system

Add system_token to old PAYG/HYBRID systems

  • Related Issue / Ticket / Trello card:

How to test

Create a system without a system_token, when auth it should have its instance identifier as a system_token

Change Type

Please select the correct option.

  • Bug Fix (a non-breaking change which fixes an issue)
  • New Feature (a non-breaking change which adds new functionality)
  • Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

  • I have reviewed my own code and believe that it's ready for an external review.
  • I have provided comments for any hard-to-understand code.
  • I have documented the MANUAL.md file with any changes to the user experience.
  • If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Review

Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.

jesusbv added 2 commits March 13, 2025 18:51
Because regsharing checks the whole key (login + pass + system_token)
all systems in the Public Cloud need to have the proper system_token

Update get_system method

Include PAYG/HYBRID system when getting the system

Add system_token to old PAYG/HYBRID systems
@jesusbv jesusbv added the 2.22 label Mar 13, 2025
@jesusbv jesusbv requested review from digitaltom and rjschwei March 13, 2025 18:54
@jesusbv jesusbv self-assigned this Mar 13, 2025
If the code reaches that method, the object is not empty
there is a previous check for `if @systems.present?`
the method is not called from anywhere else
@jesusbv jesusbv mentioned this pull request Mar 25, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants