Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system token to PAYG systems when creating the system #1297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jesusbv
Copy link
Collaborator

@jesusbv jesusbv commented Mar 13, 2025

Description

For regsharing we are querying for the whole key (login + pass + system_token) PAYG systems do not have a system token, this fixes that situation

Move the instance identifier outside SCC class

Use system token to active product and upgrade, not only announce

Add system_token value to systems without system_token if needed

  • Related Issue / Ticket / Trello card:

How to test

Register a BYOS or PAYG instance and it should have system_token populated and the value should be the instance identifier (vmId for Azure, instanceId for Amazon and instance_id for Google)

Activate LTSS on a PAYG system without system_token and should have a system_token with the right value (see above)

Change Type

Please select the correct option.

  • Bug Fix (a non-breaking change which fixes an issue)
  • New Feature (a non-breaking change which adds new functionality)
  • Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

  • I have reviewed my own code and believe that it's ready for an external review.
  • I have provided comments for any hard-to-understand code.
  • I have documented the MANUAL.md file with any changes to the user experience.
  • If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Review

Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.

For regsharing we are querying for the whole key (login + pass + system_token)
PAYG systems do not have a system token, this fixes that situation

Move the instance identifier outside SCC class

Use system token to active product and upgrade, not only announce

Add system_token value to systems without system_token if needed
@jesusbv jesusbv requested review from digitaltom and rjschwei March 13, 2025 12:30
@jesusbv jesusbv self-assigned this Mar 13, 2025
@jesusbv
Copy link
Collaborator Author

jesusbv commented Mar 13, 2025

We still need to update the system_token for PAYG systems that do not have it populated but that'd be a different PR

@jesusbv jesusbv changed the title Add system token to PAYG systems Add system token to PAYG systems when creating the system Mar 13, 2025
@jesusbv jesusbv added the 2.22 label Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant