Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check only extensions for SCC activations #1224

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

jesusbv
Copy link
Collaborator

@jesusbv jesusbv commented Sep 4, 2024

Description

When checking the registry access if system is hybrid, the check with SCC for the state of its activations should be done only with non free extensions, as base product is not free

This Fixes that scenario

How to test

on a PYG 15.4 system, register LTSS and run podman search
the result should include base product + LTSS

ip-10-3-0-101:/home/ec2-user # podman search registry-ec2.susecloud.net/
NAME                                                               DESCRIPTION
registry-ec2.susecloud.net/suse/hpc/warewulf4-x86_64/sle-hpc-node  
registry-ec2.susecloud.net/suse/ltss/sle15.4/bci-base              
registry-ec2.susecloud.net/suse/ltss/sle15.4/bci-base-fips         
registry-ec2.susecloud.net/suse/ltss/sle15.4/sle15                 
ip-10-3-0-101:/home/ec2-user # 

Change Type

Please select the correct option.

  • Bug Fix (a non-breaking change which fixes an issue)
  • New Feature (a non-breaking change which adds new functionality)
  • Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

  • I have reviewed my own code and believe that it's ready for an external review.
  • I have provided comments for any hard-to-understand code.
  • I have documented the MANUAL.md file with any changes to the user experience.
  • If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Review

Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.

When checking the registry access if system is hybrid,
the check with SCC for the state of its activations should be done
only with non free extensions, as base product is not free

This Fixes that scenario
@jesusbv jesusbv self-assigned this Sep 4, 2024
@jesusbv jesusbv requested a review from bear454 September 4, 2024 14:08
Copy link
Member

@bear454 bear454 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this to technical debt; we need to refactor to a query result, instead of querying a larger set and iterating over it.

Copy link
Contributor

@felixsch felixsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

How I reviewed this merge request:

  • Checked the code changes are fine and suggested (or not) changes I would do
  • Checked that LTSS is really a extension in SCC

As always, if you think I missed something I should test, please let me know🚀

cheers,

@jesusbv jesusbv merged commit 085f907 into master Sep 4, 2024
3 checks passed
@jesusbv jesusbv deleted the exclude-base-product-registry-access branch September 4, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants