Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating buildpack bump pipeline #357

Merged
merged 13 commits into from
Feb 3, 2020
Merged

Updating buildpack bump pipeline #357

merged 13 commits into from
Feb 3, 2020

Conversation

bikramnehra
Copy link
Contributor

@bikramnehra bikramnehra commented Jan 24, 2020

This PR intends to update the suse buildpacks pipeline in order to support recent changes in: cloudfoundry-incubator/kubecf#314

@f0rmiga f0rmiga self-requested a review January 24, 2020 00:25
@@ -2,45 +2,59 @@

set -o errexit -o nounset

# Updates release information in role-manifest
# Updates release information in values.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Updates release information in values.yaml
# Updates release information in values.yaml.

@@ -2,45 +2,59 @@

set -o errexit -o nounset

# Updates release information in role-manifest
# Updates release information in values.yaml
# Looks for a release like:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Looks for a release like:
# It looks for a release like:


PYTHON_CODE=$(cat <<EOF
#!/usr/bin/python3

import ruamel.yaml

def represent_none(self, data):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment to this function, please.

@f0rmiga f0rmiga merged commit 90ed13d into develop Feb 3, 2020
@f0rmiga f0rmiga deleted the bisingh/suse-buildpacks branch February 3, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants