Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

designate: create a test port and nslookup it #3443

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sjamgade
Copy link
Contributor

Added a basic test for designate recordset being created when a
floating ip is assigned to a port on a fixed network.

ping will not work because the port is still down as it is not assigned
to a vm. This helps test designate without
nova/glance/cinder/milkyway/... and other astronomical services.

Also fixed a type in pools file name.

JanZerebecki
JanZerebecki previously approved these changes May 20, 2019
Copy link
Contributor

@cmurphy cmurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure looks related: Error: Waiting for 'thanos port is nslookup-able' timed out.

@JanZerebecki JanZerebecki dismissed their stale review May 20, 2019 20:44

For new CI runs please ensure want_designate_proposal was set to 1, as that is not the default.

@sjamgade
Copy link
Contributor Author

I am trying to keep the size of this PR small, and therefore cannot enable testing designate, as its implementation is not entirely merged. The aim of this PR is minimum designate recordset creation test.
its become a classic chicken and egg problem.

The CI failure: Error: Waiting for 'thanos port is nslookup-able' timed out. should be fixed in the latest CI job

@JanZerebecki
Copy link
Contributor

Please rebase to fix Travis.

Added a basic test for designate recordset being created when a
floating ip is assigned to a port on a fixed network.

ping will not work because the port is still down as it is not assigned
to a vm. This helps test designate without
nova/glance/cinder/milkyway/...  and other astronomical services.

Also fixed a type in pools file name.
@sjamgade
Copy link
Contributor Author

@JanZerebecki @cmurphy could you please have another look at this ?

JanZerebecki
JanZerebecki previously approved these changes Jun 18, 2019
@JanZerebecki JanZerebecki dismissed cmurphy’s stale review June 18, 2019 16:38

CI with want_designate_proposal=1 now passes


# Run Tempest Smoketests if configured to do so
tempestret=0
if [[ $want_tempest = 1 ]]; then
openstack tld create --name com # needed by designate-template-plugin smoke test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if you don't have designate deployed ? won't this command fail ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats true, let me fix that

designate smoke test try to create a zone and recordset however they
expect the tld to already exists. So creating one.
stefannica
stefannica previously approved these changes Jul 12, 2019
[[ -e $designate_pools ]] && designate-manage pool update --file $designate_pools
designate_pools="/etc/designate/pools.crowbar.yaml"
if [[ -e $designate_pools ]]; then
designate-manage pool update --file $designate_pools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be already done by the barclamp?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the barclamp leaves a sample pool file /etc/designate/pools.crowbar.yaml" for the admin to review.

Why the barclamp doesnot do this ?
The way designate is currently installed, a zone will be created as soon as a vm is created, the only thing stopping it is "unavailability" of pool in designate. This will have security implication (allowing anyone who can create a vm to create a zone, leaking dns zone information on un-intended network, causing conflicts in dns resolution).

However this is needed to test designate, so adding it here as part of automation.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being taken care of by crowbar/crowbar-openstack#2192

designate-manage pool update --file $designate_pools
# default values from the node.neutron.dns_domain
openstack tld create --name local
openstack zone create --email admin@example.org openstack.local.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be done by the neutron integration of the barclamp?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without pools, designate cannot create zones, (so they can be XFRd to be resolvable)

Co-Authored-By: Dirk Mueller <dmueller@suse.com>
@JanZerebecki
Copy link
Contributor

Needs rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants