Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update controlled cloudflared #121

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

STRRL
Copy link
Owner

@STRRL STRRL commented Sep 14, 2024

close #99

Signed-off-by: STRRL <im@strrl.dev>
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 37.42%. Comparing base (43cc842) to head (7d6b8a5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/controller/controlled-cloudflared-connector.go 62.50% 8 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #121       +/-   ##
===========================================
+ Coverage   26.30%   37.42%   +11.12%     
===========================================
  Files          10       10               
  Lines         669      700       +31     
===========================================
+ Hits          176      262       +86     
+ Misses        483      420       -63     
- Partials       10       18        +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: STRRL <im@strrl.dev>
@STRRL STRRL merged commit f325b37 into master Sep 15, 2024
5 checks passed
@STRRL STRRL deleted the update-controlled-clodflared-if-needed branch September 15, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudflared values don't appear to be respected
1 participant