Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable use of [[no_unique_address]] attribute #6404

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Jan 7, 2024

The CMake configuration variable HPX_WITH_SUPPORT_NO_UNIQUE_ADDRESS can be used to disable the [[no_unique_address]] attribute in cases when HPX is compiled using MSVC but the code using it is compiled using clang-cl (which doesn't support this attribute on Windows before V18).

HPX_WITH_SUPPORT_NO_UNIQUE_ADDRESS defaults to ON.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.49% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c374f26) 397874 336695 84.62%
Head commit (ee2f3df) 190197 (-207677) 161870 (-174825) 85.11% (+0.49%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6404) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@hkaiser hkaiser merged commit f6f0fcd into master Jan 8, 2024
46 of 70 checks passed
@hkaiser hkaiser deleted the no_unique_address branch January 8, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant