uninitialized_relocate w/ type_support primitive #6344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isidorostsa
force-pushed
the
relocate_primitives
branch
from
5f160d6
to
f9115c5
Compare
isidorostsa
force-pushed
the
relocate_primitives
branch
from
f9115c5
to
bd32982
Compare
isidorostsa
force-pushed
the
relocate_primitives
branch
4 times, most recently
from
34dec13
to
b435397
Compare
isidorostsa
force-pushed
the
relocate_primitives
branch
from
b435397
to
fcaa2f3
Compare
isidorostsa
force-pushed
the
relocate_primitives
branch
from
91091bf
to
8531572
Compare
isidorostsa
changed the title
isidorostsa
changed the title
isidorostsa
changed the title
|
One of the builders reports: https://cdash.cscs.ch/test/104782688 |
hkaiser
previously approved these changes
Sep 10, 2023
isidorostsa
force-pushed
the
relocate_primitives
branch
from
826a9e6
to
3256dec
Compare
hkaiser
reviewed
Sep 10, 2023
libs/core/type_support/include/hpx/type_support/is_contiguous_iterator.hpp
Outdated
Show resolved
Hide resolved
isidorostsa
force-pushed
the
relocate_primitives
branch
3 times, most recently
from
2aa7101
to
b2d0ed3
Compare
hkaiser
reviewed
Sep 11, 2023
| using iter_value_type_t = | ||
| typename std::iterator_traits<Iter>::value_type; | ||
|
|
||
| template <typename Iter, typename Dummy = void> |
There was a problem hiding this comment.
Nitpick: we usually call the second parameter Enable to convey its purpose.
libs/core/type_support/include/hpx/type_support/is_contiguous_iterator.hpp
Show resolved
Hide resolved
isidorostsa
force-pushed
the
relocate_primitives
branch
from
b2d0ed3
to
a43f622
Compare
isidorostsa
force-pushed
the
relocate_primitives
branch
4 times, most recently
from
ec19c07
to
2b1610e
Compare
isidorostsa
force-pushed
the
relocate_primitives
branch
from
2b1610e
to
82f2907
Compare
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
6344: uninitialized_relocate w/ type_support primitive r=hkaiser a=isidorostsa This PR replaces the `type_support::uninitialized_relocate` with a primitive version for uninitialized relocation, named `uninitialized_relocate_n_primitive`. This is used by the parallel and sequenced versions of `algorithms::uninitialized_relocate`. In contrast to the previous attempt of implementing the relocation functions, #6314, this does not place the primitive in `transfer.hpp`, which is in the `algorithms` module, nor does it modify `loop.hpp` to add the specific exception handling method required by `uninitialized_relocate`. The goal of keeping a primitive in type support, which is relatively low level in terms of dependencies, is to use it in the higher level `small_vector` and other data structures. 6348: Adding --exclusive to launching tests on rostam r=hkaiser a=hkaiser 6349: Moving hpx::threads::run_as_xxx to namespace hpx r=hkaiser a=hkaiser - run_as_os_thread - run_as_hpx_thread Co-authored-by: isidorostsa <tsa.isidoros@gmail.com> Co-authored-by: Hartmut Kaiser <hartmut.kaiser@gmail.com>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: Response status code: 422
{"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
type_support::uninitialized_relocatewith a primitive version for uninitialized relocation, nameduninitialized_relocate_n_primitive. This is used by the parallel and sequenced versions ofalgorithms::uninitialized_relocate.In contrast to the previous attempt of implementing the relocation functions, #6314, this does not place the primitive in
transfer.hpp, which is in thealgorithmsmodule, nor does it modifyloop.hppto add the specific exception handling method required byuninitialized_relocate.The goal of keeping a primitive in type support, which is relatively low level in terms of dependencies, is to use it in the higher level
small_vectorand other data structures.