Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log alive hpx threads on exit #6340

Merged
merged 2 commits into from
Sep 10, 2023

Conversation

Pansysk75
Copy link
Member

@Pansysk75 Pansysk75 commented Sep 1, 2023

Adds logging when an HPX program is terminated suddenly (ie by a termination signal, addresses issue #6329).
I'll leave it as draft until I make up my mind on whether I think it is actually a good idea

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser hkaiser marked this pull request as ready for review September 10, 2023 13:03
@hkaiser
Copy link
Member

hkaiser commented Sep 10, 2023

bors merge

bors bot pushed a commit that referenced this pull request Sep 10, 2023
6330: Adding basic logging to collective operations r=hkaiser a=hkaiser

- flyby: fixing JeMalloc integration for dependent projects


6340: Log alive hpx threads on exit r=hkaiser a=Pansysk75

Adds logging when an HPX program is terminated suddenly (ie by a termination signal, addresses issue #6329).
I'll leave it as draft until I make up my mind on whether I think it is actually a good idea




Co-authored-by: Hartmut Kaiser <hartmut.kaiser@gmail.com>
Co-authored-by: Panos Syskakis <pansysk75@gmail.com>
@bors
Copy link

bors bot commented Sep 10, 2023

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

Response status code: 422
{"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@hkaiser hkaiser merged commit de3d0f4 into STEllAR-GROUP:master Sep 10, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants