Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BDD/RelProd #671

Merged
merged 3 commits into from
Jun 11, 2024
Merged

BDD/RelProd #671

merged 3 commits into from
Jun 11, 2024

Conversation

SSoelvsten
Copy link
Owner

Adds the foundations of #502 , i.e. it provides the trivial implementation.

@SSoelvsten SSoelvsten added ✨ feature New operation or other feature 📁 bdd Binary Decision Diagrams labels Jun 11, 2024
@SSoelvsten SSoelvsten added this to the v2.1 : Relational Product milestone Jun 11, 2024
@SSoelvsten SSoelvsten self-assigned this Jun 11, 2024
@SSoelvsten SSoelvsten changed the title Bdd/relprod BDD/RelProd Jun 11, 2024
This merely covers the API but none of the planned optimisations.
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.829%. Comparing base (e82ec26) to head (30fd7a4).

Additional details and impacted files
@@              Coverage Diff              @@
##              main      #671       +/-   ##
=============================================
+ Coverage   97.818%   97.829%   +0.011%     
=============================================
  Files           92        93        +1     
  Lines         6829      6863       +34     
=============================================
+ Hits          6680      6714       +34     
  Misses         149       149               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 11, 2024

🟡 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'ssoelvsten/adiar/bdd/relprod' is a change in performance of -0.68% (stdev: 1.97%).

... origin/main ssoelvsten/adiar/bdd/relprod
Mean 22390.60 22542.20
Standard Deviation 104.93 444.74

Number of samples: 5

Copy link

github-actions bot commented Jun 11, 2024

🟢 Regression Test (Picotrav 'adder')

'ssoelvsten/adiar/bdd/relprod' is a change in performance of 0.33% (stdev: 1.07%).

... origin/main ssoelvsten/adiar/bdd/relprod
Mean 9438.33 9407.17
Standard Deviation 101.04 70.38

Number of samples: 6

Copy link

github-actions bot commented Jun 11, 2024

🟢 Regression Test (Picotrav 'arbiter')

'ssoelvsten/adiar/bdd/relprod' is a change in performance of 14.96% (stdev: 24.10%).

... origin/main ssoelvsten/adiar/bdd/relprod
Mean 77667.60 66045.30
Standard Deviation 18714.71 268.06

Number of samples: 10

Copy link

github-actions bot commented Jun 11, 2024

🟡 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')

'ssoelvsten/adiar/bdd/relprod' is a change in performance of -0.72% (stdev: 0.75%).

... origin/main ssoelvsten/adiar/bdd/relprod
Mean 5122.50 5159.17
Standard Deviation 38.22 26.09

Number of samples: 6

Copy link

🟡 Regression Test (QBF 'domineering/5x5_13_bwnib')

'ssoelvsten/adiar/bdd/relprod' is a change in performance of -0.07% (stdev: 0.25%).

... origin/main ssoelvsten/adiar/bdd/relprod
Mean 15209.20 15220.40
Standard Deviation 37.36 23.87

Number of samples: 5

Copy link

🟡 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'ssoelvsten/adiar/bdd/relprod' is a change in performance of -0.56% (stdev: 1.18%).

... origin/main ssoelvsten/adiar/bdd/relprod
Mean 30537.50 30709.25
Standard Deviation 138.52 361.42

Number of samples: 4

Copy link

🟡 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')

'ssoelvsten/adiar/bdd/relprod' is a change in performance of -1.39% (stdev: 2.41%).

... origin/main ssoelvsten/adiar/bdd/relprod
Mean 5091.83 5162.67
Standard Deviation 33.95 124.49

Number of samples: 6

Copy link

🟢 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')

'ssoelvsten/adiar/bdd/relprod' is a change in performance of 0.31% (stdev: 0.31%).

... origin/main ssoelvsten/adiar/bdd/relprod
Mean 17430.20 17376.80
Standard Deviation 45.52 53.68

Number of samples: 5

Copy link

🟢 Regression Test (12-Queens)

'ssoelvsten/adiar/bdd/relprod' is a change in performance of 0.21% (stdev: 0.46%).

... origin/main ssoelvsten/adiar/bdd/relprod
Mean 11654.83 11629.83
Standard Deviation 54.00 37.16

Number of samples: 6

Copy link

🟡 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')

'ssoelvsten/adiar/bdd/relprod' is a change in performance of -0.37% (stdev: 0.67%).

... origin/main ssoelvsten/adiar/bdd/relprod
Mean 12129.83 12175.00
Standard Deviation 54.65 81.37

Number of samples: 6

Copy link

🟡 Regression Test (Picotrav 'mem_ctrl')

'ssoelvsten/adiar/bdd/relprod' is a change in performance of -0.16% (stdev: 0.35%).

... origin/main ssoelvsten/adiar/bdd/relprod
Mean 114192.67 114381.00
Standard Deviation 401.41 353.49

Number of samples: 3

Copy link

🟢 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')

'ssoelvsten/adiar/bdd/relprod' is a change in performance of 1.01% (stdev: 2.27%).

... origin/main ssoelvsten/adiar/bdd/relprod
Mean 9479.50 9383.83
Standard Deviation 215.43 20.66

Number of samples: 6

Copy link

🟢 Regression Test (14-Queens)

'ssoelvsten/adiar/bdd/relprod' is a change in performance of 0.41% (stdev: 3.90%).

... origin/main ssoelvsten/adiar/bdd/relprod
Mean 276866.00 275740.33
Standard Deviation 9093.74 10744.65

Number of samples: 3

@SSoelvsten SSoelvsten merged commit 183a4f3 into main Jun 11, 2024
60 checks passed
@SSoelvsten SSoelvsten deleted the bdd/relprod branch June 12, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📁 bdd Binary Decision Diagrams ✨ feature New operation or other feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant