Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encode! macro should safely return an Encoding #17

Closed
SSheldon opened this issue Mar 16, 2015 · 1 comment
Closed

encode! macro should safely return an Encoding #17

SSheldon opened this issue Mar 16, 2015 · 1 comment

Comments

@SSheldon
Copy link
Owner

The encode! macro should return an Encoding without any unsafe blocks, instead of returning a str like it currently does.

It currently allows creating some invalid encodings that would have to be fixed:

  • encode!() == ""
  • encode!(u8, u8) == "CC"
@SSheldon
Copy link
Owner Author

With specialization on the horizon, I think #26 will obviate the need for this encode! macro. In the longer term, I'd prefer a syntax extension for this rather than a procedural macro, so I don't think it's worth investing more time in this macro.

madsmtm added a commit to madsmtm/rust-objc that referenced this issue Oct 1, 2021
@madsmtm
Merge pull request SSheldon#17 from madsmtm/autoreleasepool-lifetime
1f82d5b 
Make `autoreleasepool` take the pool as a parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SSheldon