Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated URL #2279

Merged
merged 2 commits into from
Dec 31, 2021
Merged

updated URL #2279

merged 2 commits into from
Dec 31, 2021

Conversation

tiagov8
Copy link
Member

@tiagov8 tiagov8 commented Dec 21, 2021

No description provided.

JackDevAU
JackDevAU previously approved these changes Dec 24, 2021
View reviewed changes
@JackDevAU JackDevAU dismissed their stale review December 24, 2021 00:31

build errors

@tiagov8
Copy link
Member Author

tiagov8 commented Dec 24, 2021

Hey @JackDevAU did you follow up this build error?

piers-sinclair
piers-sinclair previously requested changes Dec 24, 2021
View reviewed changes
Copy link
Contributor

@piers-sinclair piers-sinclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry approved without seeing the failed check. Check needs to be fixed

@JackDevAU
Copy link
Member

Hey @JackDevAU did you follow up this build error?

Hey @tiagov8,
I'm currently investigating. This looks to be an issue with the GitHub Action we are using. From this issue trilom/file-changes-action#104 It seems upgrading to version 1.2.4 should fix it. (We are currently using 1.2.3)
I'll let you when this has been updated.

@JackDevAU JackDevAU mentioned this pull request Dec 24, 2021
Merged
@adamcogan adamcogan merged commit 0226c39 into main Dec 31, 2021
@adamcogan adamcogan deleted the tiagov8-patch-33 branch December 31, 2021 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackDevAU JackDevAU JackDevAU approved these changes

@adamcogan adamcogan adamcogan approved these changes

@piers-sinclair piers-sinclair piers-sinclair left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiagov8 @JackDevAU @adamcogan @piers-sinclair