[Port to C++] Blob Detection #85
Conversation
Signed-off-by: Khushi-Balia <khhbalia@gmail.com>
Signed-off-by: Khushi-Balia <khhbalia@gmail.com>
There was a problem hiding this comment.
@Khushi-Balia, requesting the below changes.
- Add table of content in the Readme
- Rename readme.md to
README.md - Refer convolution and filtering code structure ie have a
src,includefolders. - Refer convolution and filtering code files and follow the similar fashion for adding the comments for the functions
- Remove the unnecessary
blobfile and not required files from the folder.
Signed-off-by: Khushi-Balia <khhbalia@gmail.com>
Signed-off-by: Khushi-Balia <khhbalia@gmail.com>
|
Made the required changes. |
| - [Understanding the code](#understanding-the-code) | ||
| - [Detecting the blob](#detecting-the-blob) |
There was a problem hiding this comment.
Can be more informative if the contents in the Readme can be divided into the different topic sections similar to this
|
|
||
| tuple<double, double, double> getMedianPixelValues(Mat img); | ||
|
|
||
| #endif |
| } | ||
|
|
||
| return 0; | ||
| } |
Signed-off-by: Khushi-Balia <khhbalia@gmail.com>
|
Updated the Readme and made the changes. |
|
@Khushi-Balia when we run the code for blob detection the window that pops-up is nearly my screen size, so just make it resizable and keep initial size of window smaller for better handling |
|
@Khushi-Balia, in the Readme content there are certain part which referred to python functions. Kindly update them. Also move |
Signed-off-by: Khushi-Balia <khhbalia@gmail.com>
Signed-off-by: Khushi-Balia <khhbalia@gmail.com>
|
Made the windows resizable, updated the readme and file structure. |
There was a problem hiding this comment.
- Add a instruction of how to run the code in the Readme.
- Below is the error encountered while running the script. I think @aPR0T0 also faced the similar issue.
Signed-off-by: Khushi-Balia <khhbalia@gmail.com>
|
Resolved the error, made the necessary changes in the Makefile. |
Signed-off-by: Khushi-Balia <khhbalia@gmail.com>
|
@Khushi-Balia, resize is not working. I guess you need to first define the window then resize it. |
Signed-off-by: Khushi-Balia <khhbalia@gmail.com>
|
Changed the window size and updated the readme. |
Signed-off-by: Khushi-Balia <khhbalia@gmail.com>
Signed-off-by: Khushi-Balia <khhbalia@gmail.com>
|
@Khushi-Balia, update the PR according to the new file structure. |
amanchhaparia
changed the title
Signed-off-by: Khushi-Balia <khhbalia@gmail.com>
Resolve #51