Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Masking implementation in C++ and Sample image #73

Merged
merged 15 commits into from
Mar 28, 2023

Conversation

advait-0
Copy link
Contributor

@advait-0 advait-0 commented Feb 21, 2023

This code creates a transparent png image and tries to get a background free png image from the "fake" png's users might have downloaded.
This is a simple code and requires the user to create a range for the RGB range to be ignored (masked) and retains and writes the remaining part to the newly created png.

Resolve #55

@amanchhaparia
Copy link
Collaborator

amanchhaparia commented Feb 22, 2023

@notad22, add a Readme.md file and its proper documentation. Also instead of dumping all the algorithm in the main create a separate function by dividing the algorithm into smaller chunk of logic. Add a Makefile for compiling your task.

@advait-0 advait-0 marked this pull request as draft February 22, 2023 08:18
@advait-0 advait-0 marked this pull request as ready for review February 23, 2023 17:59
@amanchhaparia
Copy link
Collaborator

@notad22, too much theory in the readme.md, try to make it more intuitive.

Copy link
Collaborator

@amanchhaparia amanchhaparia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Rename readme file to README.md.
  • Add table of contents in readme.
  • Add illustration of the code example.

Copy link
Collaborator

@amanchhaparia amanchhaparia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove 5_masking.hpp
  • Create a assets folder and put images under it.

@amanchhaparia amanchhaparia merged commit 4743187 into SRA-VJTI:dev Mar 28, 2023
Khushi-Balia pushed a commit to Khushi-Balia/Pixels_Seminar that referenced this pull request Mar 28, 2023
* Added Masking implementation in C++ and Sample image

* Added Makefile for file specific usage and Readme

* Updated code with functions for ease-of-use

* Fixed image filename error

* Updated file naming convention

* Delete 5_Masking_Basics.cpp

Fixed file structure

* Added Masking theory

* Updated readme for better readability

* Update readme with examples

* Update with added TOC and rename to README.md

* Delete 5_masking.hpp

* Update README with illustrations and fix minor errors

* Update file structure, documentation, improve makefile and remove hpp dependency

* minor fixes

* remove unused assets

---------

Co-authored-by: Lakshaya Singhal <singhallakshaya@gmail.com>
Co-authored-by: “Advait <“advaitdhamorikar@gmail.com”>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants