-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convolutions tasks divided into different files #123
Conversation
@PritK99, please checkout the PR and let me know if any change is required. |
Why are folders such as |
@advait-0 Could you please review this PR and suggest changes. |
In the benchmarks folder time taken by each convolution is also being printed. In order to Benchmark(time taken by convolution operation), we would have to perform convolution, so the folders |
@AryanNanda17 please add the usage instructions to run each file in the sub-folder readme. |
@advait-0, I made the required changes please check it out. |
Hello @AryanNanda17, Please add benchmarks to each file or remove them from the separable convolutions as they all should have a common standard. The point of the benchmark here is to understand the reason behind the use of separable convolutions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add / remove benchmarks
Hello @aPR0T0, could you please elaborate on this? |
Sure @AryanNanda17 , makes sense then. Great work! Just a small change, add benchmark ka example execution in readme |
Thanks! |
@aPR0T0, I added the results of Benchmarks in Readme. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4_cv_basics/4_convolutions_filtering/convolutionUsingOpenCV.cpp
Outdated
Show resolved
Hide resolved
Please make the change of removing unnecessary files and merge the benchmarking code into one file @AryanNanda17. Good job so far! |
Hello @SuperChamp234!
|
Hello @AryanNanda17 , that's right we need to simplify the code Just restructure the directories as ->
and inside benchmark just keep cpp files, this way the folder remains generic |
@aPR0T0, I made the changes. Please check it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Great work @AryanNanda17 !
This issue involves refactoring the provided convolution code into three separate files, each focusing on a specific aspect of convolution operations, and creating a separate folder for benchmarking the results of each file.
Resolved issue #120