Issue resolved #117 #119
Issue resolved #117 #119
Conversation
Update build configuration to include SDL2 Changed CFLAGS to include SDL2 directories using `pkg-config --cflags sdl2`. Changed LIBS to include SDL2 libraries using `pkg-config --libs sdl2`. Fixes SRA-VJTI#117
Update build configuration to include SDL2 Changed CFLAGS to include SDL2 directories using `pkg-config --cflags sdl2`. Changed LIBS to include SDL2 libraries using `pkg-config --libs sdl2`. Fixes SRA-VJTI#117
Update directory name and source file linking in build instructions
| @@ -5,9 +5,9 @@ CC = g++ | |||
| PROJECT = image_representation | |||
|
|
|||
| # Here Include specifies which directories can be added in the include path of the main.cpp | |||
| CFLAGS = -std=c++11 $(shell pkg-config --cflags opencv4) -Iinclude/ | |||
| CFLAGS = -std=c++11 $(shell pkg-config --cflags opencv4) $(shell pkg-config --cflags sdl2) | |||
There was a problem hiding this comment.
were cflags necessary for sdl2?
didn't it work without them?
There was a problem hiding this comment.
no it's not working without --cflags sdl2
There was a problem hiding this comment.
Then why did it work before in linux? As there was no cflag before
There was a problem hiding this comment.
It does not work because the directory structure is slightly different in macOS, therefore giving an error for SDL2/SDL.h
There was a problem hiding this comment.
It does not work because the directory structure is slightly different in macOS, therefore giving an error for
SDL2/SDL.h
Sure, got it!
There was a problem hiding this comment.
I think then this change is good to go
| # What libraries to be imported here it is opencv and SDL | ||
| LIBS = $(shell pkg-config --libs opencv4) -lSDL2 | ||
| LIBS = $(shell pkg-config --libs opencv4) $(shell pkg-config --libs sdl2) |
| @@ -5,9 +5,9 @@ CC = g++ | |||
| PROJECT = playing_with_images | |||
|
|
|||
| # Here Include specifies which directories can be added in the include path of the main.cpp | |||
| CFLAGS = -std=c++11 $(shell pkg-config --cflags opencv4) -Iinclude/ | |||
| CFLAGS = -std=c++11 $(shell pkg-config --cflags opencv4) $(shell pkg-config --cflags sdl2) | |||
There was a problem hiding this comment.
Same here, were cflags necessary here?
There was a problem hiding this comment.
Here, the cflags is not necessary since we are not using the sdl2 library in this folder's code.
There was a problem hiding this comment.
Here, the cflags is not necessary since we are not using the sdl2 library in this folder's code.
@Ritika128 make the necessary changes in the next commit
Removed sdl2 dependency
|
This request looks reasonable, so merging it to the main branch |
Updated 4_cv_basics/1_image_representation/Makefile
Updated 4_cv_basics/2_playing_with_images/Makefile
Fixes Issue #117
Updated 4_cv_basics/3_interpolation/README.md