Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some cel seastone platform api failed cases #237

Merged
merged 3 commits into from
Mar 3, 2021
Merged

fix some cel seastone platform api failed cases #237

merged 3 commits into from
Mar 3, 2021

Conversation

qnos
Copy link

@qnos qnos commented Feb 22, 2021

- What I did

  1. fix some failed cases in sfp module
  2. fix some failed cases in thermal module

- How I did it

  1. Some API return type and value is not correct, for example, expect list type but return bool type. Fix it by correct the return type.
  2. Some API not support, add support to it.

- How to verify it
Run the Jenkins to show the new testbed platform test result.

    1. failed cases in sfp module
    2. failed cases in thermal module
@119064273
Copy link

@cel-eric pylint check yet?

@qnos
Copy link
Author

qnos commented Feb 23, 2021

@cel-eric pylint check yet?

No introduce new pylint issue, I fixed some pylint warning in thermal, there still many remains in sfp module.

root cause:
    sensor file in /usr/share/sonic/platform is mount as ro,
    do not write this file in pmon
@mudsut4ke mudsut4ke self-requested a review March 3, 2021 08:29
@mudsut4ke mudsut4ke merged commit 32af83c into SONIC-DEV:master_dx010_fix_failed_test_cases_of_api Mar 3, 2021
mudsut4ke pushed a commit that referenced this pull request Jan 28, 2022
Why I did it
Update pointer to this commit in sonic-snmpagent:

a07da53 2021-10-26 Removed unused variables in rfc2863.py (#237)
mudsut4ke pushed a commit that referenced this pull request Jan 28, 2022
…t#9412)

c2aac75 [SFP-Refactor] Fix LP mode API issue (#247)
dba17c8 Firmware upgrade CLI support for QSFP-DD transceivers (#244)
cd69212 [SFP-Refactor] Implement CMIS Low Power mode (#237)
9cea07f Fix RegGroupField decode (#245)
6ae1909 Add CMIS QSFP support (#246)
c1f317d Gracefully handle CMIS APIs for passive modules (#238)
ec7335d fix for firmware functions  (#243)
cf2ebe9 Fix RegBitField decode/encode (#242)
ef4f2c6 Fix SFP_CABLE_TECH_FIELD (#240)
e118644 remove time counting message in functions because function running time could be difficult to predict in unit tests (#241)

Signed-off-by: Prince George <prgeor@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants