-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove what Command From Integration Tests #73
Conversation
This commit replaces the use of the what command for finding the root directory of the source code with the function WecOptLib.utils.getSrcRootPath. getSrcRootPath is also updated to generate a nicer looking result.
Oh, b*lls. It ran the older library for the tests. Hang on, I'll prove it works.... |
Yeah, having two installs of the toolbox is weird, but here you go: |
Hey Mat there are issues using cd in Linux (and probably MacOS?) I'll send you the errors when the test finish |
Linux failing on cd |
Sterling what does |
K>> WecOptLib.utils.getSrcRootPath()
ans =
'gpfs1/ssolson/WecOptTool' |
OK, the path was not absolute on linux. Give that a try. |
can we also start using |
Yes, I think that's a good idea, but I'm not going to do it now. |
All pass Linux |
Alright, I'll use this in the new release candidate. |
All tests pass on Windows with multiple WecOptTools. But here is something interesting. I ran the test from Documents/WecOptTool but it saved the tests in Desktop/alphaWOT/WecOptTool. This definitely does not work as expected with multiple installations, but we can worry about this in the future. |
I mean I think if you install it twice you should expect some strange results! |
We should add a note in the docs to uninstall first if using the stable version to avoid this fun happening to folks. |
Good point. I don't know how to "uninstall". |
* Add note about removal of existing installations * Fix NEMOH Files section for current process
I added an update to the README for users to uninstall if they have existing versions. |
This commit replaces the use of the what command for finding the root directory of the source code with the function WecOptLib.utils.getSrcRootPath.
getSrcRootPath is also updated to generate a nicer looking result.
Test results (with two installations of WecOptLib):
test_results.pdf