Fix projected band plot with 2 colour #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajjackson
reviewed
Oct 6, 2022
| @@ -603,8 +603,8 @@ def get_projected_plot( | |||
|
|
|||
| # if only two orbitals then just use red and blue | |||
| if len(weights) == 2: | |||
| weights = np.insert(weights, 1, np.zeros(weights[0].shape), axis=0) | |||
| colours = ["#ff0000", "#0000ff"] | |||
| weights = np.insert(weights, 2, np.zeros(weights[0].shape), axis=0) | |||
There was a problem hiding this comment.
Am I right in thinking it was this insertion index which caused the weird behaviour with custom colours?
There was a problem hiding this comment.
Yeah exactly, the weights has shape (n_projections, nbands, nkpoints). We inserted the dummy weights between the two existing weights, so the colours should correspond to the 1st and 3rd colours. But instead we only set 2 colours.
|
I spent a few minutes trying to break this and it seems fine. |
|
Thanks for double checking Adam! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #180
Changed the defaults of colour1, colour2 and colour3 from red, green, blue to red, blue, green to make it easier to reproduce the expected behaviour with 2 colours.