Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo #28

Merged
merged 3 commits into from
Feb 21, 2018
Merged

typo #28

merged 3 commits into from
Feb 21, 2018

Conversation

skyreflectedinmirrors
Copy link
Collaborator

No description provided.

@skyreflectedinmirrors
Copy link
Collaborator Author

Two minor bugs I encountered re-running performance data for the new paper.

  • The first is just a silly mistake I made in fixing possible bug in default third-body efficiency #26 (is_pdep -> pdep)
  • The second has to do with an environment change on the testing machine, NVCC is now off the path such that I don't detect NVIDIA's OpenCL runtime (and this breaks the poorly formatted subprocess call, which should be fixed anyways)

@kyleniemeyer
Copy link
Member

should bump the minor version number and issue a new release after merging this

@kyleniemeyer
Copy link
Member

which reminds me, please update the CHANGELOG 😄

@skyreflectedinmirrors
Copy link
Collaborator Author

@kyleniemeyer I think you need to issue the release IIRC, it's on your pypi account.
I updated the changelog and version

@kyleniemeyer
Copy link
Member

I can do it, but the pip/conda release is done by Travis when it detects a new version tag, so it doesn't matter who does it.

@skyreflectedinmirrors skyreflectedinmirrors merged commit d7e138f into SLACKHA:master Feb 21, 2018
@skyreflectedinmirrors
Copy link
Collaborator Author

@kyleniemeyer not sure if that triggered it?

https://github.com/SLACKHA/pyJac/releases/tag/v1.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants