Migrate to pydantic v2 #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still not done - needs more work
Update everything to the pydantic v2 way, meaning use classmethods __get_pydantic_core_schema__ and __get_pydantic_json_schema__, drastically minimizing the class, but also making it a bit more opaque. Use model_copy() instead of copy(). Remove dependency on sessions containing Python objects - rely only on pure JSON types in the session object.
What it does (recursively dump all models as dicts) is the default behaviour in pydantic v2 now, so there is no need for this functionality.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
+ Coverage 74.04% 74.31% +0.27%
==========================================
Files 15 14 -1
Lines 628 549 -79
==========================================
- Hits 465 408 -57
+ Misses 163 141 -22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It was found to be necessary when used in certain core OTEAPI strategies. It may be relevant to have all the pydantic_core.Url properties readily available. Also, make the OPTIMADE accessUrl further variable by making the host a changeable environment variable (OPTIMADE_HOST).
Cap supported Python versions at 3.11 due to DLite not supporting Python 3.12 and above.
…c-v2' into cwa/close-163-migrate-to-pydantic-v2
Release v0.2.0 now supports pydantic v2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #163