Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to instantiate str variable before adding to it #323

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

CasperWA
Copy link
Collaborator

Fixes #322

AI Summary

This pull request includes updates to the .pre-commit-config.yaml file and improvements to error handling in the setver.py script.

Configuration updates:

Error handling improvements:

  • ci_cd/tasks/setver.py: Enhanced the error message construction by initializing the msg variable as an empty string and appending additional information conditionally.

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.37%. Comparing base (5aac677) to head (3f03dbd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
+ Coverage   84.61%   85.37%   +0.76%     
==========================================
  Files          12       12              
  Lines         936      937       +1     
==========================================
+ Hits          792      800       +8     
+ Misses        144      137       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CasperWA CasperWA merged commit 8dbfea9 into main Feb 19, 2025
25 checks passed
@CasperWA CasperWA deleted the cwa/fix-322-bug-in-setver branch February 19, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix bug in setver task
1 participant