fix: product categories and collections are not updating due to wrong request type #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGFGOV
approved these changes
May 1, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| logger.error('Error occur while receiving strapi signal.', { | ||
| 'error.message': e.message, | ||
| }); | ||
| res.status(500).send('Error occur while receiving strapi signal - ' + e.message); |
Check warning
Code scanning / CodeQL
Exception text reinterpreted as HTML
Comment on lines
+1625
to
+1636
| this.logger.error('Error occur while sending request to strapi', { | ||
| 'error.message': theError, | ||
| request: { | ||
| url: endPoint || 'none', | ||
| data: JSON.stringify(data) || 'none', | ||
| method: method || 'none', | ||
| }, | ||
| response: { | ||
| body: JSON.stringify(error?.response?.data) ?? 'none', | ||
| status: error?.response?.status ?? 'none', | ||
| }, | ||
| }); |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! I have noticed that the product categories and collections are not updating properly.
After doing some investigations, I believe this is due to an issue with the wrong request type being used.
Also:
I am happy to modify or remove logging changes from the PR.