Make comparisons not ambiguous (fixes clang warnings) #1703
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previoulsy had a bunch of clang warnings that looked like this:
These were the result of a few changes to the C++20 standard. The warnings were exclusively located in the coordinate system templates.
I think I fixed this issue now by removing the
operator!=
implementation (which should be generated implicitely now) and using a differentoperator==
overload. This gets rid of the warnings completely.