Make util::constexpr_ consteval
#1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heinezen
added
improvement
TheJJ
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
util::constexpr_contains helper functions for the openage logger that should be evaluated at compile-time. However, at least for me, these functions were still evaluated at runtime instead. This created a lot of unnecessary call to these functions, especiallystrip_prefix, when logging messages. The log messages take up a giant amount of resources in the event loop for example, due to the frequent calls to the logger.Since C++20 can enforce compile-time evaluation with the
constevalkeyword, so I replaced allconstexprspecifiers in the namespace with that. I also changed the name of the namespace toutil::consteval_to make this change more clear.