-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable Activities #1609
Configurable Activities #1609
Conversation
a8ffed9
to
6a46710
Compare
6a46710
to
cf0fda6
Compare
bc962b1
to
7549a9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
progress!
return {db_view->get_object(next->get_name())}; | ||
} | ||
// 1+ next nodes | ||
case activity::node_t::XOR_GATE: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be part of the xorgate node implementation instead of this central place? might be a suitable application of a std variant and stdvisit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to integrate nyan too deep into the gamestate. That's why these helper classes exist as a kind of layer between nyan and openage. I think this also makes it easier to maintain the API when we change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but isn't the xorgate node class the abstraction layer? so instead of having specific snippets here, having them more local to the specific code using it seems more local.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this would make more sense though. The function here is only used to traverse the activity graph defined in the modpack, so it doesn't have much to do with activities at runtime. It's only use is to create the runtime activity from the nyan definition. XorGate and the other nodes have their own internal next
function for traversing the runtime graph.
7549a9e
to
0e7178f
Compare
73d51f8
to
ec381df
Compare
Makes the activity system configurable with nyan.
engine
modpack versionXorGate
/XorEventGate