Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an inappropriate test expression to remove a logical short circuit #1559

Merged
merged 3 commits into from
Oct 8, 2023
Merged

Fix an inappropriate test expression to remove a logical short circuit #1559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32274ba
Comment: Fixed an inappropriate test expression to remove a logical s…
munahaf Oct 6, 2023
eacac66
Changed test expression per reviewer's suggestion.
munahaf Oct 6, 2023
9422cbe
Added name for the following PR https://github.com/SFTtech/openage/pu…
munahaf Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions copying.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ _the openage authors_ are:
| Martin | Starman | mstarman à seznam dawt cz |
| Zoltán Ács | zoli111 | acszoltan111 à gmail dawt com |
| Trevor Slocum | tslocum | trevor à rocket9labs dawt com |
| Munawar Hafiz | munahaf | munawar dawt hafiz à gmail dawt com |

If you're a first-time committer, add yourself to the above list. This is not
just for legal reasons, but also to keep an overview of all those nicknames.
Expand Down
2 changes: 1 addition & 1 deletion openage/convert/processor/conversion/aoc/processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,7 +663,7 @@ def create_building_lines(full_data_set: GenieObjectContainer) -> None:

upgrade_effects = effect_bundle.get_effects(effect_type=3)

if len(upgrade_effects) < 0:
if len(upgrade_effects) == 0:
continue

# Search upgrade effects for the line_id
Expand Down