Skip to content

Commit

Permalink
etc: Move Pretty print TODOs to the top of the module.
Browse files Browse the repository at this point in the history
  • Loading branch information
heinezen committed Apr 19, 2024
1 parent e2bca02 commit d46f0d4
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions etc/gdb_pretty/printers.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
import re
import gdb # type: ignore

# TODO: Printers should inherit from gdb.ValuePrinter when gdb 14.1 is available in all distros.


class PrinterControl(gdb.printing.PrettyPrinter):
"""
Expand Down Expand Up @@ -109,8 +111,6 @@ def format_fixed_point(value: int, fractional_bits: int) -> float:
class CoordPrinter:
"""
Pretty printer for openage::coord types (CoordNeSe, CoordNeSeUp, CoordXY, CoordXYZ).
TODO: Inherit from gdb.ValuePrinter when gdb 14.1 is available in all distros.
"""

def __init__(self, val: gdb.Value):
Expand Down Expand Up @@ -150,8 +150,6 @@ def children(self):
class TimePrinter:
"""
Pretty printer for openage::time::time_t.
TODO: Inherit from gdb.ValuePrinter when gdb 14.1 is available in all distros.
"""

def __init__(self, val: gdb.Value):
Expand Down Expand Up @@ -182,8 +180,6 @@ def children(self):
class FixedPointPrinter:
"""
Pretty printer for openage::util::FixedPoint.
TODO: Inherit from gdb.ValuePrinter when gdb 14.1 is available in all distros.
"""

def __init__(self, val: gdb.Value):
Expand Down Expand Up @@ -220,8 +216,6 @@ def children(self):
class VectorPrinter:
"""
Pretty printer for openage::util::Vector.
TODO: Inherit from gdb.ValuePrinter when gdb 14.1 is available in all distros.
"""

def __init__(self, val: gdb.Value):
Expand Down Expand Up @@ -267,8 +261,6 @@ def display_hint():
class KeyframePrinter:
"""
Pretty printer for openage::curve::Keyframe.
TODO: Inherit from gdb.ValuePrinter when gdb 14.1 is available in all distros.
"""

def __init__(self, val: gdb.Value):
Expand Down

0 comments on commit d46f0d4

Please sign in to comment.