Fix some warnings #235
Merged
Fix some warnings #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vittorioromeo
force-pushed
the
feature/fix_some_warnings
branch
from
a9e8cd6 to
eae0246
Compare
| @@ -231,7 +231,7 @@ struct WindowContext { | |||
| lastCursor = ImGuiMouseCursor_COUNT; | |||
|
|
|||
| joystickId = getConnectedJoystickId(); | |||
| for (int i = 0; i < sf::Joystick::ButtonCount; ++i) { | |||
| for (int i = 0; i < static_cast<int>(sf::Joystick::ButtonCount); ++i) { | |||
There was a problem hiding this comment.
Looks like an SFML/SFML bug we ought to fix. We shouldn't use a signed int for a count like this. But that's outside the scope of this PR.
| @@ -1164,7 +1168,7 @@ void RenderDrawLists(ImDrawData* draw_data) { | |||
| } | |||
|
|
|||
| ImGuiIO& io = ImGui::GetIO(); | |||
| assert(io.Fonts->TexID != (ImTextureID)NULL); // You forgot to create and set font texture | |||
| assert(io.Fonts->TexID != (ImTextureID) nullptr); // You forgot to create and set font texture | |||
There was a problem hiding this comment.
Do we even need to do that cast to ImTextureID? Maybe that's out of scope of this PR though.
There was a problem hiding this comment.
I think this cast was needed to calm down some other compiler warnings :)
(Well, I found this.)
eliasdaler
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes various warnings, including: "unhandled values in switch", "implicit conversion from signed to unsigned".