cron: Remove too greedy file context grab #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regexp will match lots of unintended files, for example things created by tempfile patterns (could include "cron"), and also things inside subdirectories. It feels like a better approach would be to find actual directories used, or at the very least to limit it to files directly under /run. Signed-off-by: Henrik Grindal Bakken <henribak@cisco.com>
hbakken
force-pushed
the
work/remove-excessive-cron-regexp
branch
from
5a0a9a0
to
e62996c
Compare
pebenito
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regexp will match lots of unintended files, for example things created by tempfile patterns (could include "cron"), and also things inside subdirectories.
It feels like a better approach would be to find actual directories used, or at the very least to limit it to files directly under /run.
It's possible just removing it is too harsh, but I feel at least it should be changed.