Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transactions template to portfolio summary #4891

Merged
merged 35 commits into from
Dec 12, 2024

Conversation

perryr16
Copy link
Contributor

@perryr16 perryr16 commented Dec 5, 2024

Any background context you want to provide?

Better Buildings has several data report templates they plan to use. One of which is a Transactions template used to track eui per transaction

Sample Transactions Template: 2024_DataReviewReport_TransactionTemplate_Returning Franchisees_4.8.2024.xlsb.zip

What's this PR do?

It incorporates the BB transaction template into the existing Portfolio Summary. The Goal model has been updated to include a "type" field that has choices of "standard" or "transaction", and a nullable "transactions_column". Regardless of goal type, the same endpoints are hit, but the frontend will interpret them differently based on the "type" field. The transactions template differs from the standard by using an additional "transactions" column to calculate the weighted EUI per restaurant transaction.

The fields included in the standard goal are: Area, kBtu, EUI, Area Change, EUI Change
The fields included in the transaction goal are: Area, kBtu, Transactions, EUI(s), EUI(t), Area Change, Transactions Change, EUI(s) change, and EUI(t) change.

How should this be manually tested?

Sample Data
12props_eui_2021_2022_2023.xlsx
The above has 12 properties across 3 different cycles (2021-2023). After creating those cycles, perform a multicycle upload.

To test, create a few goals of both types and confirm expected functionality.

What are the relevant tickets?

#4892

Screenshots (if appropriate)

Screenshot 2024-12-05 at 1 43 24 PM

@perryr16 perryr16 added the Feature Add this label to new features. This will be reflected in the change log when generated. label Dec 5, 2024
@perryr16 perryr16 changed the base branch from develop to portfolio-summary-move-to-backend December 5, 2024 20:40
@perryr16 perryr16 changed the base branch from portfolio-summary-move-to-backend to develop December 5, 2024 20:41
@perryr16 perryr16 marked this pull request as ready for review December 6, 2024 18:56
@kflemin kflemin self-requested a review December 11, 2024 22:17
Copy link
Contributor

@kflemin kflemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💰

@kflemin kflemin merged commit b263b70 into develop Dec 12, 2024
9 checks passed
@kflemin kflemin deleted the portfolio-summary-transactions branch December 12, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Add this label to new features. This will be reflected in the change log when generated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants