-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transactions template to portfolio summary #4891
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move functionality to backend dev - meeds pagination dev - meeds pagination added pagination labels functional naming logging
clean up
perryr16
added
the
Feature
Add this label to new features. This will be reflected in the change log when generated.
label
Dec 5, 2024
perryr16
changed the base branch from
develop
to
portfolio-summary-move-to-backend
December 5, 2024 20:40
perryr16
changed the base branch from
portfolio-summary-move-to-backend
to
develop
December 5, 2024 20:41
kflemin
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💰
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature
Add this label to new features. This will be reflected in the change log when generated.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
Better Buildings has several data report templates they plan to use. One of which is a Transactions template used to track eui per transaction
Sample Transactions Template: 2024_DataReviewReport_TransactionTemplate_Returning Franchisees_4.8.2024.xlsb.zip
What's this PR do?
It incorporates the BB transaction template into the existing Portfolio Summary. The Goal model has been updated to include a "type" field that has choices of "standard" or "transaction", and a nullable "transactions_column". Regardless of goal type, the same endpoints are hit, but the frontend will interpret them differently based on the "type" field. The transactions template differs from the standard by using an additional "transactions" column to calculate the weighted EUI per restaurant transaction.
The fields included in the standard goal are: Area, kBtu, EUI, Area Change, EUI Change
The fields included in the transaction goal are: Area, kBtu, Transactions, EUI(s), EUI(t), Area Change, Transactions Change, EUI(s) change, and EUI(t) change.
How should this be manually tested?
Sample Data
12props_eui_2021_2022_2023.xlsx
The above has 12 properties across 3 different cycles (2021-2023). After creating those cycles, perform a multicycle upload.
To test, create a few goals of both types and confirm expected functionality.
What are the relevant tickets?
#4892
Screenshots (if appropriate)