Inventory groups frontend edits

[perryr16]

Any background context you want to provide?

What's this PR do?

• Adds db constraint to inventory groups requiring unique name
• Adds validation to group creation. The group and it's inventory must share an ALI.
• Adds ability to choose an ALI if an empty group is created
• Adds Group Map page
• Adds temp partials and controllers for inventory group dashboard, systems & services, and meters
• Various improvements

How should this be manually tested?

Sample test files
ali_tree_better_buildings_lite.xlsx
AH_BB_250props100_lat_long.xlsx
AH_BB_250props100_lat_long_diag.xlsx - Same properties, but properties lat has been updated

• Upload property info with ALI and lat/long info to cycle 1. Upload 2nd file to cycle 2.
• Go to Inventory List > Groups > Create Group > create 2 groups for 2 different leaf nodes node
• Go to Inventory List > Select properties of a leaf node > Actions > Add to/Remove from Groups > Add button for the group with a matching ALI should be enabled, and the group with a mismatched ALI should be disabled
• Select properties from different ALIs > Actions > Add to/Remove from Groups > should see a warning that the selected views do not meet group requirements. Create is disabled, all adds are disabled.
• Go to Groups > click group name > navigate through Inventory Group Detail pages. The "Properties" and "Map" tab cycle dropdowns should update data to reflect cycle inventory

What are the relevant tickets?

Screenshots (if appropriate)

[haneslinger]

Just reviewed things server side.

[haneslinger]

💯 💯 💯

[haneslinger]

you could replace L39-40 with this

Suggested change

	access_level_instance_data = AccessLevelInstanceSerializer(many=False, read_only=True)

[haneslinger]

remove

[haneslinger]

fyi, treebeard has a built in function that's very similar. you might not need this.

[haneslinger]

there's for sure places in the code base where I should have used treebeard functions but rewrote them myself. 😅

[perryr16]

Could you elaborate on this? I was attempting to remove repetition when filtering for model instances within an ali. This pattern is used all over, and could be replaced by the filter in the above code, but I didn't want to make changes to dozens of files without approval.

self.model.objects.filter(
                    organization_id=self.get_organization(self.request),
                    property__access_level_instance__lft__gte=access_level_instance.lft,
                    property__access_level_instance__rgt__lte=access_level_instance.rgt,
                )

[haneslinger]

firstly, the code you quoted above cannot be replaced by this function. it's missing "property__".

Secondly, if you don't need the "property__", and are just looking for the tree under an ali, .get_descendants does that

[perryr16]

You're right, the function would need to accept a prefix argument.

I played around with .get_descendants() and it's not quite right. .get_descendants() returns descendants of the node, but not the current node. So to get current and descendants, there are 4 db queries, while the original only uses 2. Let me know if you have a more elegant solution :)

access_level_instance = AccessLevelInstance.objects.get(pk=access_level_id)
current_and_descendants = AccessLevelInstance.objects.filter(id=access_level_id) | access_level_instance.get_descendants()
groups = groups.filter(access_level_instance__in=current_and_descendants)

[haneslinger]

ah, you're right. Maybe get_tree()?

[perryr16]

.get_tree returns the entire tree, sisters, aunts, ... everything

[haneslinger]

even if you pass the current node as an arg? Its a class method

[perryr16]

oh, thats perfect!