Major dependency update #4806
Merged
Major dependency update #4806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelstudios
added
DO NOT MERGE
Maintenance
axelstudios
force-pushed
the
task/dependency-update
branch
7 times, most recently
from
f2a92e2 to
4b1a23b
Compare
axelstudios
force-pushed
the
task/dependency-update
branch
2 times, most recently
from
47b4ec1 to
855c2f0
Compare
haneslinger
reviewed
Oct 1, 2024
| @@ -13,6 +13,9 @@ | |||
|
|
|||
|
|
|||
| class SensorViewSet(generics.GenericAPIView, viewsets.ViewSet, OrgMixin, ProfileIdMixin): | |||
| # For the Swagger page, GenericAPIView asserts a value exists for `queryset` | |||
| queryset = Sensor.objects.none() | |||
There was a problem hiding this comment.
why none and not all? I see mostly alls in the existing codebase.
There was a problem hiding this comment.
This is only for the benefit of Swagger - it doesn't need to actually hit the database, it only needs the queryset property to exist
haneslinger
reviewed
Oct 1, 2024
| @@ -1076,7 +1076,7 @@ def test_get_location(self): | |||
| location, status = _get_location(self.property_view) | |||
| self.assertEqual(status, "success") | |||
| self.assertTrue(location is not None) | |||
| self.assertEqual(location, "730 Garcia Street, Boring, Oregon, 97080") | |||
| self.assertEqual(location, "1070 Hunt Street, Boring, Oregon, 97015") | |||
There was a problem hiding this comment.
Pretty sure this one comes from bumping Faker from v0.9.3 to v29.0.0. Somewhere along the way they changed their algorithm for generating addresses and such
axelstudios
force-pushed
the
task/dependency-update
branch
4 times, most recently
from
6ce06d3 to
2722c8d
Compare
…nx spelling issues, fixed sphinx-build on Windows, removed unused code
…fixed type checking
axelstudios
force-pushed
the
task/dependency-update
branch
from
2722c8d to
6a64ce6
Compare
axelstudios
force-pushed
the
task/dependency-update
branch
from
6a64ce6 to
3c2cde8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
manage.py flush_dbcommand that wipes all database contents (and restarts table sequences) except for static tables (EEEJ and Uniformat)django-autoslugdependencyNullBooleanField<class 'seed.views.v3.sensors.SensorViewSet'> is not compatible with schema generation<class 'seed.views.v3.tax_lot_properties.TaxLotPropertyViewSet'> is not compatible with schema generationnpm testto support both port 80 and 8000How should this be manually tested?
Monkey test, tests should pass
For local testing, you'll (obviously) need to run
pip install -r requirements/test.txt