PySD 2.0.0

[enekomartinmartinez]

Dependencies dictionary added:

1. Improving caching strategy
2. Improving initialization of Stateful objects
3. Other possible future applications (graph generation...)

Manage model components:

1. Components class to load model and manage them, allowing inline changes
2. Control variables managing through Time class, allowing dynamic final_time, time_step and saveper.

Several bug fixes (modulo, exponentials)

General cleanup

Improvement of the documentation

[pep8speaks]

Hello @enekomartinmartinez! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file pysd/py_backend/vensim/vensim2py.py:

Line 153:80: E501 line too long (93 > 79 characters)

• In the file tests/integration_test_vensim_pathway.py:

Line 46:80: E501 line too long (83 > 79 characters)
Line 209:80: E501 line too long (93 > 79 characters)

Comment last updated at 2021-11-08 15:39:32 UTC

[enekomartinmartinez]

My bad that docs didn't work in the building, I need to update an import.
I will also add some unit test for new components class.

[coveralls]

Coverage increased (+1.1%) to 99.826% when pulling 86160d5 on new_components into 5885d62 on master.

[enekomartinmartinez]

HI @JamesPHoughton,
seems that the problem with the documentation is a recent bug about the version of sphinx that uses ReadTheDocs https://githubmemory.com/repo/ivadomed/ivadomed/issues/973

I have updated setup.py as in the example provided in the previous issue. However, we need to change the RTD configuration to use the "docs" extra_packages.

I have no access to modify this configuration in RTD could you manage that or give me access? Thanks :)

[enekomartinmartinez]

@JamesPHoughton I was able to solve the RTD issue by adding the readthedocs.yaml file. Now it works fine.
By my side this PR is ready to be merged.

[JamesPHoughton]

Changes are great, a few documentation things I noticed. Good to merge when you're ready.

Congratulations!

[JamesPHoughton]

Are these todo's still open? (and ln 371/2, 399?)

[enekomartinmartinez]

Yes, this are two features that I didn't add and we have no test that cover this lines.
I tried to add tests for those lines but I don't know how the original files should look like.
Line 371 is quite more complicated as it is related about how the subscripts are defined.

[JamesPHoughton]

Would this model be useful to include in the test-models repo? Not sure if its something other people would find useful?

[enekomartinmartinez]

This model is related to the dependencies dict and multiples dependencies. In fact, it is not run by integration test but used unit_test_pysd.py for testing these multiple dependencies management. I don't think that this will be useful for other projects, as it is just a simple copy of test_subscript_individually_defined_stocks.mdl with some small changes to test the dependencies.