Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue when Indicator is hidden, which still preserve the layout on watchOS (have no issues on iOS/tvOS/macOS) #75

Merged
merged 2 commits into from
Jan 30, 2020

Conversation

dreampiggy
Copy link
Collaborator

The ZStack does not response to the inner aspectRatio modifier on watchOS (works on iOS/tvOS/macOS). Thanks Apple :)

…ut on watchOS (have no issues on iOS/tvOS/macOS)
@dreampiggy dreampiggy added the apple bug Apple's bug that need workaround label Jan 30, 2020
@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #75 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   72.42%   72.34%   -0.09%     
==========================================
  Files           9        9              
  Lines         671      669       -2     
==========================================
- Hits          486      484       -2     
  Misses        185      185
Flag Coverage Δ
#ios 72.34% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
...DWebImageSwiftUI/Classes/Indicator/Indicator.swift 52.63% <ø> (-4.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee786be...0cde522. Read the comment docs.

@dreampiggy dreampiggy force-pushed the bugfix_indicator_watchOS branch from 0f6eff4 to 0cde522 Compare January 30, 2020 04:25
@dreampiggy dreampiggy merged commit 4d35d16 into master Jan 30, 2020
@dreampiggy dreampiggy deleted the bugfix_indicator_watchOS branch January 30, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apple bug Apple's bug that need workaround
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant