Refactory and introduced the convenient transition API on WebImage, compatible for SwiftUI Animation #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… works as SwiftUI standard UI component, .fade transition is only fade in
dreampiggy
force-pushed
the
feature_convenient_transition_API
branch
2 times, most recently
from
81a6dc3 to
d624d04
Compare
…Image/AnimatedImage
dreampiggy
force-pushed
the
feature_convenient_transition_API
branch
from
d624d04 to
634f8a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previouslly, there is a bug that custom transition API does not works as expected (like the
.move)Fix this by arrange the
WebImagebody structure, now SwiftUI can recognize it and work as expected.Note that the
.opacitywill cause both fade-out (placeholder) and fade-in (network image). For most cases, use.fadeis better.