Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Important changes]Trying to move the initial state setup before onAppear to fix the watchOS switching url or any other state issue #316

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

dreampiggy
Copy link
Collaborator

@dreampiggy dreampiggy commented Apr 29, 2024

This maybe a behavior changes, need testing

I have no extra time to test, so just release another patch version and please test this (seems work well on example)

This close #312
This close #314

And maybe many many other issue which related to the onAppear behavior of SwiftUI.

@dreampiggy dreampiggy added behavior Some behavior changes watchos labels Apr 29, 2024
@dreampiggy
Copy link
Collaborator Author

Hi. @alfredcc

I just remove the platform differences code, in example the issue seems disappeared. But I don't have a real world App to test.

I'll release a patch version (v3.0.4) and you can have a test with this to see the result.

…atchOS switching url or any other state issue

This maybe a behavior changes, need testing
@dreampiggy dreampiggy force-pushed the try_fix_watchOS_switch_nil_url branch from c5f6404 to 5f8a8ac Compare April 29, 2024 10:24
@dreampiggy dreampiggy added this to the 3.0.4 milestone Apr 29, 2024
@dreampiggy dreampiggy merged commit 3876ce2 into master Apr 29, 2024
6 checks passed
@dreampiggy dreampiggy changed the title Trying to move the initial state setup before onAppear to fix the watchOS switching url or any other state issue [Important changes]Trying to move the initial state setup before onAppear to fix the watchOS switching url or any other state issue Apr 29, 2024
@dreampiggy dreampiggy deleted the try_fix_watchOS_switch_nil_url branch April 29, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior Some behavior changes watchos
Projects
None yet
1 participant