Feature: Support indicator and transition on WebImage/AnimatedImage
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing SDWebImage's already supported features
…based solution, and with SwiftUI Binding for isAnimating and progress
…SProgressIndicator
…her platform does not have this issue
…l still exist. Now we remove all the view when finished. Fix the example
dreampiggy
force-pushed
the
feature_indicator_transition
branch
from
3e0603b to
aaff0d7
Compare
…sure syntax, which is more convenient and swifty
dreampiggy
force-pushed
the
feature_indicator_transition
branch
from
aaff0d7 to
63b6da1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indicator
AnimatedImageUse the
SDWebImageIndicatorfor implementation, already supported by SDWebImageWebImageCreate a new struct
Indicator, which allows to receive a closure with two args, oneBinding<Bool>for animation, anotherBinding<CGFLoat>for progress control. Which is also the design like SDWebImageCreate the all convienet methods like
ActivityIndicator/ProgressIndicatorusing System type. WatchOS does not support any system UI element, sadlly. Use your own (SeeProgressBarin example)Transition
AnimatedImageUse the
SDWebImageTransitionfor implementation, already supported by SDWebImageWebImageSwiftUI provide a really good implementationi
AnyTransition, you can use.transition(_:)modifier. So we don't need to do anything for this. Updated example to enable transition (fade with 0.5 seconds)