Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the support for image data observable on ImageManager #107

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

dreampiggy
Copy link
Collaborator

@dreampiggy dreampiggy commented Apr 30, 2020

Add the support to observe the image data loaded success. This is used for user who want to have some extra setup logic for image data (not image bitmap object (UIImage).

However, due to the API semversion, we can not break current onSuccess API, which only receive the (UIImage, SDImageCacheType). Which will be changed in v2.0.0

So I just only add the imageData published property on manager.

See #104

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #107 into master will increase coverage by 2.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   72.78%   74.82%   +2.04%     
==========================================
  Files           9        9              
  Lines         823      878      +55     
==========================================
+ Hits          599      657      +58     
+ Misses        224      221       -3     
Flag Coverage Δ
#ios 74.82% <100.00%> (+2.04%) ⬆️
Impacted Files Coverage Δ
SDWebImageSwiftUI/Classes/ImageManager.swift 80.72% <100.00%> (+5.00%) ⬆️
SDWebImageSwiftUI/Classes/WebImage.swift 84.18% <0.00%> (+4.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e61e44...2341575. Read the comment docs.

@dreampiggy dreampiggy merged commit 8a347dc into master Apr 30, 2020
@dreampiggy dreampiggy deleted the add_data_observable branch April 30, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant