Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop SVGKit support to another repo, using iOS 13/macOS 10.15 native CoreSVG instead #10

Merged
merged 12 commits into from
Nov 13, 2019

Conversation

dreampiggy
Copy link
Collaborator

@dreampiggy dreampiggy commented Nov 13, 2019

This PR move the current SVGKit implementation to another new repo: SDWebImageSVGKitPlugin.

Because of SVGKit itself, is no longer actively maintained, and contains many issues which is hard for us to catch.

Instead, iOS 13/ macOS 10.15 's new CoreSVG.framework works well for most of cases, and it's provided by Apple. More stable and ready for future.

This can also make this framework, works for our SwiftUI user, see: SDWebImage/SDWebImageSwiftUI#50

This close #9.

@dreampiggy dreampiggy merged commit aabf0ca into master Nov 13, 2019
@bpoplauschi bpoplauschi deleted the iOS13_SVG branch November 13, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Drop SVGKit support and use SVG-Native standard for mobile system
1 participant