Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRTR Performance Improvement #520

Merged
merged 1 commit into from
Nov 19, 2022
Merged

Conversation

JamesWekel
Copy link
Contributor

Fish,

Here is a proposed performance improvement for the TRTR instruction.

Before the change, the performance test reported:

         1,000,000 iterations of TRTR  took   4,556,698 microseconds
         1,000,000 iterations of TRTR  took   4,780,255 microseconds
         1,000,000 iterations of TRTR  took   5,106,327 microseconds

and after the change:

         1,000,000 iterations of TRTR  took     213,195 microseconds
         1,000,000 iterations of TRTR  took     243,271 microseconds
         1,000,000 iterations of TRTR  took     244,445 microseconds

The performance increase is about 95%.

Please note that I've copied

#undef  MAINSTOR_PAGEBASE
#define MAINSTOR_PAGEBASE( _ma )  ((BYTE*) ((uintptr_t) ( _ma ) & PAGEFRAME_PAGEMASK)) 

from general1.c (CUSE improvement) to general2.c for crossed page tests. Hate duplication but I wasn't sure where a single copy should be placed.

Thank you for your review and updates.

Jim

Copy link
Member

@Fish-Git Fish-Git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty simple and solid to me! Pull Request approved! Well done, James!

@Fish-Git Fish-Git merged commit 99d7fd0 into SDL-Hercules-390:develop Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants