Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set TEMPLATE rule to install_pool for the Ninja tool #4668

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

adamscott
Copy link
Contributor

This PR changes the TEMPLATE rule pool from local_pool (which seems to match the number of jobs supplied) to install_pool (which runs at half of the number of jobs supplied).

It seems to solve #4667

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated CHANGES.txt and RELEASE.txt (and read the README.rst).
  • I have updated the appropriate documentation

@bdbaddog bdbaddog linked an issue Dec 17, 2024 that may be closed by this pull request
@bdbaddog
Copy link
Contributor

@adamscott - Please also add a blurb to RELEASE.txt?

@adamscott
Copy link
Contributor Author

@bdbaddog Done! I updated the text in CHANGES.txt too.

@bdbaddog bdbaddog merged commit c76a8c5 into SCons:master Dec 17, 2024
6 of 8 checks passed
@mwichmann mwichmann added this to the 4.9 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Ninja build race condition with the ninja_daemon_build.py
3 participants