Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -prerelease for MSVC 2022 #4051

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

bdbaddog
Copy link
Contributor

@bdbaddog bdbaddog commented Nov 5, 2021

Remove prerelease flag for MSVC 2022 in prep for SCons 4.3 release and MSVC 2022 release.

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated CHANGES.txt (and read the README.rst)
  • I have updated the appropriate documentation

@bdbaddog bdbaddog added the MSVC Microsoft Visual C++ Support label Nov 5, 2021
@LeonarddeR
Copy link

Is there anything against supporting building with preview versions of Visual Studio on request? VS2022 has just been released but the first minor update has landed in the preview channel. If I understand this pr correctly, it removes support for preview versions.

@mwichmann
Copy link
Collaborator

That support will appear as part of a different change, to address #4048. The maintainer wanted to split the topics.

@bdbaddog
Copy link
Contributor Author

bdbaddog commented Nov 8, 2021

Is there anything against supporting building with preview versions of Visual Studio on request? VS2022 has just been released but the first minor update has landed in the preview channel. If I understand this pr correctly, it removes support for preview versions.

There was never a released version of SCons with support for pre-release MSVC.
The implementation in question isn't one we'd like to release.
So that logic is being removed.
We'll release SCons today/tomorrow with 2022 support and then figure out a comprehensive (and SCons'ian) way to support prerelease going forward. Hopefully soon.

As @mwichmann said any further discussion should happen in #4048

@SCons SCons locked as resolved and limited conversation to collaborators Nov 8, 2021
@bdbaddog bdbaddog merged commit fd0c6e4 into SCons:master Nov 8, 2021
@bdbaddog bdbaddog deleted the remove_msvc22_prerelease branch November 9, 2021 03:01
@mwichmann mwichmann added this to the 4.3 milestone Nov 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
MSVC Microsoft Visual C++ Support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants