Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MDS adapt option to capVol test #454

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Add MDS adapt option to capVol test #454

wants to merge 3 commits into from

Conversation

bobpaw
Copy link
Collaborator

@bobpaw bobpaw commented Sep 13, 2024 •
edited
Loading

Add MDS adapt option to capVol test

  • Add -m flag to convert mesh to MDS during adapt and back to CRE afterward.
  • Use ma::adapt instead of ma::adaptVerbose.
  • Use default ma::Input.
  • Add new cap.* tests that run with MDS.

TODO

  • Tests are taking longer because I'm using ma::adapt instead of ma::adaptVerbose.

Comparison:

test case adapt adaptVerbose adapt+pre-fix
capVolCube 1884.35 sec 149.71 sec 333.62 sec
capVolCubeMds 191.51 sec 27.05 sec 87.63 sec
capVolWing 5963.82 sec 203.11 sec 454.72 sec
capVolWingMds 821.70 sec 56.86 sec 40.10 sec

@bobpaw
Convert to MDS mesh during adapt for capVol
df9e2fa 
- Add -m option to convert mesh database to MDS during adaptation. This
  option speeds up adaptation.
- This tests the conversion capability.

Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
@bobpaw
Clean up capVol
fa27b8d 
- Replace writeCre with cs.save_file.
- Replace ma::adaptVerbose with ma::adapt (the production version).
- Remove ma::Input arguments which are just reinforcing the defaults.
  - If the defaults chagne we shouldn't force using the old ones.
- Don't delete old mesh model before adapting.
- Change CapstoneModule name.
- Reorder mds mesh after conversion.

Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
@bobpaw
Add mds adapts to capVol test matrix
537b4e3 
- Disable verify() for non-volume meshes.

Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bobpaw