fix: handles BSI query URL exception or SSL errors for python 3.8 to 3.11 #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n 3.8 and 3.11 inclusive
fabiolsilva
reviewed
Jun 6, 2023
Comment on lines
+316
to
+317
| if (isinstance(URLe.reason, ssl.SSLCertVerificationError) and URLe.reason.verify_code == 62) \ | ||
| or (isinstance(URLe.reason, ssl.SSLError) and URLe.reason.errno == 5): |
There was a problem hiding this comment.
Added additional reason and error code to make this compatible with Python 3.8-3.11.
fabiolsilva
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handling of exceptions to query the Italy BSI catalog (due to SSL certificates not being quite alright on their API) must be different from python 3.8 and 3.11 In 3.8, the reason is thrown as a ssl.SSLCertVerificationErros, whereas in 3.11 it is thrown just as a ssl.SSLError, both of which has different codes or error numbers.
Fixed that issue, to the query works for python versions from 3.8 up to 3.11
Type of change:
Please delete options that are not relevant.
Checklist: