Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gCMT Catalog accessor #217

Merged
merged 2 commits into from
May 30, 2023
Merged

gCMT Catalog accessor #217

merged 2 commits into from
May 30, 2023

Conversation

pabloitu
Copy link
Collaborator

Added gcmt accessor from ISC API. Follows the same logic than comcat and bsi readers. Created test for an event search and summary info from a request.

pyCSEP Pull Request Checklist

Please check out the contributing guidelines for some tips
on making pull requests to pyCSEP.

Fixes issue #(please fill in or delete if not needed).

Type of change:

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pabloitu pabloitu changed the title added gcmt accessor from ISC API. Follows the same logic than comcat… gCMT Catalog accessor Apr 11, 2023
csep/utils/readers.py Outdated Show resolved Hide resolved
…and bsi readers. Created test for an event search and summary info from a request.
…e.iris.edu/fdsnws/event/1/") in text file, which is faster and safer.

tests: fixed event list location
@pabloitu
Copy link
Collaborator Author

reworked into reading gcmt from IRIS instead of ISC, which takes less time and gives less query issues.

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

Codecov Report

Patch coverage: 66.27% and project coverage change: +0.42 🎉

Comparison is base (c19ce9f) 54.63% compared to head (19eaabd) 55.05%.

❗ Current head 19eaabd differs from pull request most recent head 533e2a2. Consider uploading reports for the commit 533e2a2 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   54.63%   55.05%   +0.42%     
==========================================
  Files          22       23       +1     
  Lines        3904     3954      +50     
  Branches      650      656       +6     
==========================================
+ Hits         2133     2177      +44     
- Misses       1636     1641       +5     
- Partials      135      136       +1     
Impacted Files Coverage Δ
csep/__init__.py 26.25% <24.13%> (-0.04%) ⬇️
csep/utils/readers.py 46.85% <75.00%> (+0.77%) ⬆️
csep/utils/iris.py 92.68% <92.68%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pabloitu
Copy link
Collaborator Author

*note: In the tests/build workflow, the conda environment build is taking too long

conda env update --file requirements.yml

and sometimes it gives up of building the environment and just fail the workflow. We maybe should build the environment differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants