Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes issue #140 to add support for spatial forecasts #142

Merged
merged 3 commits into from
Oct 6, 2021

Conversation

wsavran
Copy link
Collaborator

@wsavran wsavran commented Oct 5, 2021

also fixes import issues with spatial poisson likelihood function

@wsavran
Copy link
Collaborator Author

wsavran commented Oct 5, 2021

@khawajasim do you mind taking a look at this and seeing if it solves your problem

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2021

Codecov Report

Merging #142 (f42a502) into master (7686eda) will increase coverage by 0.05%.
The diff coverage is 83.33%.

❗ Current head f42a502 differs from pull request most recent head 5d93510. Consider uploading reports for the commit 5d93510 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   56.88%   56.94%   +0.05%     
==========================================
  Files          19       19              
  Lines        3157     3161       +4     
  Branches      457      458       +1     
==========================================
+ Hits         1796     1800       +4     
  Misses       1250     1250              
  Partials      111      111              
Impacted Files Coverage Δ
csep/core/poisson_evaluations.py 42.72% <50.00%> (+0.26%) ⬆️
csep/utils/calc.py 54.78% <100.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7686eda...5d93510. Read the comment docs.

@khawajasim
Copy link
Contributor

Hi. Thanks for the fix. This looks good and should work.

Kind Reagrds

@wsavran wsavran merged commit dc48a52 into SCECcode:master Oct 6, 2021
@wsavran wsavran deleted the whs_fix_issue_140 branch October 6, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants