Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add serialization to regions for json formatted catalog #138

Merged
merged 4 commits into from
Oct 20, 2021

Conversation

wsavran
Copy link
Collaborator

@wsavran wsavran commented Aug 24, 2021

  • supports new region versions e.g., QuadTreeRegion
  • added region comparison using to_dict method in regions

- supports new region versions e.g., QuadTreeRegion
- added region comparison using to_dict method in regions
@wsavran wsavran requested a review from pabloitu August 24, 2021 00:36
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2021

Codecov Report

Merging #138 (e03514f) into master (065ae2d) will increase coverage by 0.03%.
The diff coverage is 49.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   56.88%   56.92%   +0.03%     
==========================================
  Files          19       19              
  Lines        3157     3197      +40     
  Branches      457      468      +11     
==========================================
+ Hits         1796     1820      +24     
- Misses       1250     1258       +8     
- Partials      111      119       +8     
Impacted Files Coverage Δ
csep/core/regions.py 52.61% <42.85%> (+0.41%) ⬆️
csep/core/forecasts.py 54.41% <50.00%> (ø)
csep/core/catalogs.py 60.18% <72.72%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 065ae2d...e03514f. Read the comment docs.

output computing metrics by default when iterating over catalog forecasts
cleaned up docstrings
@wsavran
Copy link
Collaborator Author

wsavran commented Oct 6, 2021

pull request is still in progress.

@pabloitu
Copy link
Collaborator

Its working okay with my regions. Merging

@pabloitu pabloitu merged commit 5a1485a into SCECcode:master Oct 20, 2021
@wsavran
Copy link
Collaborator Author

wsavran commented Oct 20, 2021

nice thanks @pabloitu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants