Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed catalog plotting options. #134

Merged
merged 2 commits into from
Jul 24, 2021
Merged

Conversation

pabloitu
Copy link
Collaborator

The magnitude ticks defined as default in catalog.plot() were spurious, and created problems if the magnitude range of the catalog was not in a similar range. The default now for magnitude legend elements are numpy.linspace(min(mw_range), max(mw_range), 4). Rounding of the magnitude is to one decimal, but only in the legend text. Raise a warning, if the passed magnitude_ticks are outside of the catalog mw range.

… are numpy.linspace(min(mw_range), max(mw_range), 4). Rounding of the magnitude is to one decimal, but only in the legend text.
@wsavran
Copy link
Collaborator

wsavran commented Jul 22, 2021

cool i will test this out.

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2021

Codecov Report

Merging #134 (552bae2) into master (4195021) will not change coverage.
The diff coverage is n/a.

❗ Current head 552bae2 differs from pull request most recent head 528348d. Consider uploading reports for the commit 528348d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   57.06%   57.06%           
=======================================
  Files          19       19           
  Lines        3142     3142           
  Branches      454      454           
=======================================
  Hits         1793     1793           
  Misses       1238     1238           
  Partials      111      111           
Impacted Files Coverage Δ
csep/core/catalogs.py 60.07% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4195021...528348d. Read the comment docs.

… title name default for plot_spatial_dataset()
@wsavran wsavran merged commit e0d0065 into SCECcode:master Jul 24, 2021
@wsavran
Copy link
Collaborator

wsavran commented Jul 24, 2021

i like the default changes to the plots

@pabloitu pabloitu deleted the catalogplot_fix branch November 11, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants