Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XSS Vulnerabilities in 2.8 #2116

Open
7 tasks
AdisonCavani opened this issue Feb 25, 2022 · 0 comments
Open
7 tasks

XSS Vulnerabilities in 2.8 #2116

AdisonCavani opened this issue Feb 25, 2022 · 0 comments
Assignees
@Limraj
Labels
vulnerability
Milestone
2.8.0

Comments

@AdisonCavani
Copy link
Collaborator

AdisonCavani commented Feb 25, 2022 •
edited by Limraj
Loading

Describe the bug
This issue reports about XSS vulnerabilities found on Scada-LTS 2.8 with security patch applied in #2103

List of bugs

  • In Data sources, Name of DataSource is not escaped
  • In Data sources, Point name of DataSource is not escaped
  • In Data source edit, Name of Point is not escaped
  • In Data point details, Point name and Name of DataSource is not escaped
  • In Data point properties, Data Point name, Data Source name, Text renderer properties, Event text renderer properties, Event detectors is not escaped
  • In WatchLists, Data Point name is not escaped
  • In Graphical Views, Component Chart Comparator and Link is not escaped

Data test
Scada-LTS_xss.zip

Desktop (please complete the following information):
@Limraj Limraj modified the milestones: 2.8.0, 2.7.4 Oct 31, 2022
@Limraj Limraj modified the milestones: 2.7.4, 2.7.5 Nov 30, 2022
@Limraj Limraj modified the milestones: 2.7.5, 2.7.6 Jan 13, 2023
@Limraj Limraj assigned Patrykb0802 and Limraj and unassigned Patrykb0802 Aug 7, 2023
Limraj added a commit that referenced this issue Aug 14, 2023
@Limraj
#2116 XSS Vulnerabilities in 2.8 - fix dataSourceList.jsp, dataPointE…
6d6da98 
…dit.jsp, dataPointDetails.jsp, users.jsp, editMeta.jsp, eventTextRenderer.jsp, pointName.jsp, pointProperties.jsp, textRenderer.jsp; added function: removeScriptTag in common.js; added method: DataPointEditDwr.removeScriptTag;
Limraj added a commit that referenced this issue Aug 17, 2023
@Limraj
#2116 XSS Vulnerabilities in 2.8 - revert DataPointEditDwr.java, comm…
76d73ae 
…on.js; corrected: attractor point list - editVirtual.jsp, eventTextRenderer.jsp, textRenderer.jsp, dataSourceEdit.jsp, watchList.jsp
Limraj added a commit that referenced this issue Aug 17, 2023
@Limraj
#2116 XSS Vulnerabilities in 2.8 - refactoring: added function conver…
f6165d5 
…tToText to common.js
Limraj added a commit that referenced this issue Aug 17, 2023
@Limraj
#2116 XSS Vulnerabilities in 2.8 - corrected
e1295c4
Limraj added a commit that referenced this issue Aug 22, 2023
@Limraj
#2116 XSS Vulnerabilities in 2.8 - added ScadaEscapeUtils.java; fixed…
000eb44 
… ChartComparatorComponent.java
@Limraj Limraj modified the milestones: 2.7.6, 2.7.7 Aug 23, 2023
@Limraj Limraj modified the milestones: 2.7.7, 2.7.8 Oct 26, 2023
@Limraj Limraj modified the milestones: 2.7.8, 2.7.9 Feb 29, 2024
@Limraj Limraj modified the milestones: 2.7.9, 2.8.0 Jul 7, 2024
@Limraj Limraj mentioned this issue Jul 14, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Limraj Limraj

Labels
vulnerability
Projects
None yet
Milestone
2.8.0
Development

No branches or pull requests
3 participants
@Limraj @Patrykb0802 @AdisonCavani